feat: file upload notification for datasets #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-1247.dev.renku.ch |
lorenzo-cavazzi
requested changes
Feb 18, 2021
There was a problem hiding this comment.
All good! Just a note on the text for the successful operation.
For the user, it's not clear he can move away from the page while uploading. I was tempted to suggest adding such a message, but probably that would just clog the UI even more. We could consider this later if we think it's useful.
|
I suggest the following:
|
vfried
force-pushed
the
1150-file-ds-notification
branch
from
618d865
to
644f6bf
Compare
|
I just pushed new changes, if the file is bigger than 100MB they will see the message. Otherwise, they won't.
|
vfried
force-pushed
the
1150-file-ds-notification
branch
from
641e1a8
to
0f2fdcb
Compare
ciyer
previously approved these changes
Feb 24, 2021
vfried
force-pushed
the
1150-file-ds-notification
branch
from
a4a2a6a
to
d636298
Compare
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all files finished uploading on a dataset add/edit
When a file failed
/deploy
Closes #1150