Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): redesign of projects search bar #1281

Merged
merged 4 commits into from
Mar 22, 2021

Conversation

vfried
Copy link
Contributor

@vfried vfried commented Mar 17, 2021

This PR addresses ONLY the search bar

Before:
image

After:
image

Collapsed Before:
image

Collapsed After:
image

/deploy

@vfried vfried requested a review from a team as a code owner March 17, 2021 14:03
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1281.dev.renku.ch

@vfried vfried temporarily deployed to renku-ci-ui-1281 March 17, 2021 14:14 Inactive
@vfried vfried temporarily deployed to renku-ci-ui-1281 March 17, 2021 15:31 Inactive
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I see that you have deviated from the design document in a few places, and I think most make sense, but I wanted clarify a few things illustrated by this image here:

image

  • What font weight should we use for "Renku Projects"? Here it is regular/400, the designer specified medium/500, but I think demi-bold/600 also looks good.
  • Should we say "Filter by..." or "Search..." I lean to "Search" because it may be less technically correct, but I think it is simpler to understand
  • I think we should try to emulate the look of the "Order by: " selection that comes from the designer.
  • If you mouse over the interactive widgets of the search bar like the search input field, the search domain dropdown or the order by dropdown, they become larger (I think padding or something increases), disturbing the layout

@@ -26,4 +26,4 @@
}

//boostrap font family overwrite
$font-family-base: 'Calcutta-Medium';
$font-family-base: 'Calcutta-Regular', sans-serif;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be Calcutta, sans-serif. That makes it possible for css to select different weights: normal/400, medium (I think 500), bold/700, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, you are right about this, i tried this but for some reason it didn't work, but it works now so i changed this to

$font-family-base: 'Calcutta', sans-serif;

  • Filter vs Search should be search
  • Renku Projects font weight... in my opinion there is not much difference, i would like to make it the same for all text in that H* so that it's consistent. For now i left things to what bootstrap sets and i like it.
  • Order by changed to look like luca designed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very experienced with fonts, i will leave them like this for now and we could overwrite bootstraps values when we know what we want, maybe you could do it if you know better. Otherwise, i will give it a try.

Something else to consider is that Luca sent us the fonts for Regular and Medium but there are actually versions of the fonts for more weights the problem is we only have them in woff (i think) and we would need to have them also in eot, ttf and svc... this can be done with online converters if we would want to have the font in all the weights, I'm just not sure how bootstrap will use them... i tried to read about this but couldn't find anything in the documentation about it.

@vfried vfried changed the base branch from 1241-top-bar-design to ui-design-2021 March 19, 2021 15:20
@vfried vfried changed the title feat(design): redesign of project search bar feat(design): redesign of projects search bar Mar 21, 2021
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good. The design is starting to come together! 🚀

@vfried vfried merged commit 8afe14d into ui-design-2021 Mar 22, 2021
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

@ciyer ciyer added this to the 0.11.9 milestone Apr 1, 2021
@ciyer ciyer deleted the 1241-project-search-bar branch April 1, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants