Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header takes up less vertical space #1420

Merged
merged 5 commits into from
Aug 2, 2021
Merged

Header takes up less vertical space #1420

merged 5 commits into from
Aug 2, 2021

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jul 12, 2021

Changes

Desktop

image

Mobile

image

/deploy renku=ui-design-2021

Fix #1389

@ciyer ciyer requested a review from a team as a code owner July 12, 2021 13:31
ciyer pushed a commit that referenced this pull request Jul 12, 2021
@ciyer ciyer requested a review from vfried July 14, 2021 11:54
@vfried
Copy link
Contributor

vfried commented Jul 15, 2021

This looks really good, i'm on a smaller screen now and it can really make a difference to have a bit more space in the screen.

Two things to point out:

  • padding in the search bar when things are collapse should not be 4... to achieve this you can change the "pe-4" for "pe-0 pe-lg-4" that should do it.
  • It would be nice if the amount of space on top and bottom of the frog is the same and to have a bit more space under the search field, etc... we could maybe add some internal padding for this or make the padding on top smaller. --> adding a pb-2 where the nav.navbar is should fix this.

It would be good if Luca reviews this as well, to see that it looks good. But it's not 100% necessary.

@ciyer
Copy link
Contributor Author

ciyer commented Jul 15, 2021

This looks really good, i'm on a smaller screen now and it can really make a difference to have a bit more space in the screen.

Two things to point out:

I made these changes:

image

image

@vfried
Copy link
Contributor

vfried commented Jul 15, 2021

All looks good buuuuut... there is one last issue i found here: when things are collapsed the bar is bigger (height) than when they are not.

@ciyer
Copy link
Contributor Author

ciyer commented Jul 15, 2021

All looks good buuuuut... there is one last issue i found here: when things are collapsed the bar is bigger (height) than when they are not.

Yes, I need to add a little bit of vertical space because the elements were too squashed together, and it didn't look good.

@vfried vfried temporarily deployed to renku-ci-ui-1420 July 27, 2021 09:55 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1420.dev.renku.ch

@vfried vfried temporarily deployed to renku-ci-ui-1420 July 27, 2021 10:28 Inactive
@vfried vfried temporarily deployed to renku-ci-ui-1420 July 27, 2021 13:44 Inactive
@vfried vfried temporarily deployed to renku-ci-ui-1420 July 27, 2021 15:21 Inactive
@vfried vfried temporarily deployed to renku-ci-ui-1420 July 28, 2021 13:54 Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! 👍

I've re-run the acceptance tests cause they were missing the reference to the renku branch renku=ui-design-2021

@vfried vfried merged commit 41e4b44 into master Aug 2, 2021
@RenkuBot
Copy link
Contributor

RenkuBot commented Aug 2, 2021

Tearing down the temporary RenkuLab deplyoment for this PR.

@ciyer ciyer added this to the 1.0.0 milestone Oct 1, 2021
@ciyer ciyer deleted the 1389-small-header branch October 11, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design: make header smaller
5 participants