-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header takes up less vertical space #1420
Conversation
This looks really good, i'm on a smaller screen now and it can really make a difference to have a bit more space in the screen. Two things to point out:
It would be good if Luca reviews this as well, to see that it looks good. But it's not 100% necessary. |
All looks good buuuuut... there is one last issue i found here: when things are collapsed the bar is bigger (height) than when they are not. |
Yes, I need to add a little bit of vertical space because the elements were too squashed together, and it didn't look good. |
You can access the deployment of this PR at https://renku-ci-ui-1420.dev.renku.ch |
c34e27f
to
f7c15ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! 👍
I've re-run the acceptance tests cause they were missing the reference to the renku branch renku=ui-design-2021
Tearing down the temporary RenkuLab deplyoment for this PR. |
Changes
Desktop
Mobile
/deploy renku=ui-design-2021
Fix #1389