Support Cloud Storage

[ciyer]

Add support to the UI for mounting cloud storage buckets.

The interaction with the backend still needs to be sorted out. Error handling/information is non-existent at the moment. See SwissDataScienceCenter/renku-notebooks#729.

TODO

• use server_options to decide if the cloud storage is available or not

Screenshots

Testing

Things that should be tested

• Enter just an endpoint or just a bucket name, that should not be allowed
• Trying to use the same bucket name is used multiple times should be prevented

Follow-up

• Validate cloud storage credentials before start: Currently, if the credentials are wrong, the session just does not come up and no explanation is given why. We should validate the credentials in the ui-server before start, so we can prevent this situation from arising.

Fix #1499

/deploy renku-notebooks=cloud-storage-naming-tweaks-for-testing #persist

[RenkuBot]

You can access the deployment of this PR at https://renku-ci-ui-1518.dev.renku.ch

[olevski]

Btw after talking to Andrea it just occured to me that we should mention somewhere in the UI that:

1. The buckets that you specify will be mounted under /cloudstorage/<bucket_name>
2. If you mount multiple buckets their names have to be unique - among all buckets you specify (regardless of provider) the bucket names have to be unique. This is simply because you cannot have two mountpoint/folders with the same name under /cloudstorage where all the buckets are mounted

And one more thing that Andrea rightfully brought up. The error messages from the notebook service do not trickle down to the UI. This is not a new thing, or something that has been introduced with this PR. I think the best way forward here is to merge this PR - the S3 feature is off by default so we can decide to keep it off until we roll out proper error messaging.

Here is the PR that will standardize error messages in the notebook service: SwissDataScienceCenter/renku-notebooks#849. I just need to do a few changes/cleanup on it and we can merge this on the notebook side. But the API that the ui will use will not change at all with these edits that I mention. So if you want you can start to adapt the ui to this new format of error messages from the notebook service.

[ciyer]

Btw after talking to Andrea it just occured to me that we should mention somewhere in the UI that:

1. The buckets that you specify will be mounted under /cloudstorage/<bucket_name>
2. If you mount multiple buckets their names have to be unique - among all buckets you specify (regardless of provider) the bucket names have to be unique. This is simply because you cannot have two mountpoint/folders with the same name under /cloudstorage where all the buckets are mounted

Those are good suggestions, I will add them to the UI.

And one more thing that Andrea rightfully brought up. The error messages from the notebook service do not trickle down to the UI. This is not a new thing, or something that has been introduced with this PR. I think the best way forward here is to merge this PR - the S3 feature is off by default so we can decide to keep it off until we roll out proper error messaging.

That makes sense. The other part of the solution is mentioned in the main text of the description above: we want to validate the credentials in the ui-server when the user clicks "Save." Then we can immediately provide feedback that the user can fix. But this PR is already big enough, and that feature can be added in later.

[olevski]

@ciyer I only tested out launching a session and looked at how my previous two comments were addressed. So all of that is fine.

I did not review the code at all. Since I am not familiar with the code that all I will leave that to someone else from the UI team.

[andre-code]

Great feature 🎉👏
My only minor suggestion would be to rename the session test file to newSession.spec.ts since there is another PR that is adding a session file to display the session list.

🚀

[ciyer]

Great feature 🎉👏 My only minor suggestion would be to rename the session test file to newSession.spec.ts since there is another PR that is adding a session file to display the session list.

🚀

Sure, good idea -- maybe that rename can be in the other PR though. :)

[RenkuBot]

Tearing down the temporary RenkuLab deplyoment for this PR.