Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): restore projects data used by datasets #1656

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

lorenzo-cavazzi
Copy link
Member

This fixes a bug spotted by @gavin-k-lee that prevents datasets to be added to projects.

How to test: look for a dataset using the dataset search, open any and click on the "Add to project" button on the top right.
The user should be able to look for a project again and import the dataset (if the target project is up-to-date).
Trying the some on dev won't work -- the user won't even be able to select a target project.

P.S. We should probably check also the source project version. That may not be straightforward in the current implementation.
I would suggest re-working a bit the "add to project" logic, removing the overcomplicated FormGenerator Autosuggest (it's half-bugged, not checking for the input data to be available and not filtering some unusable target projects), adding the required logic for checking migrations on both sides.

/deploy renku=1.0-next renku-graph=development renku-core=v1.0.2

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner January 21, 2022 13:55
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1656 January 21, 2022 13:55 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1656.dev.renku.ch

Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Thanks for putting this fix together.

When testing the UI, if I actually attempt to add a dataset to a project, I get this error:

image

Is this just a misconfiguration of the deployment?

@lorenzo-cavazzi
Copy link
Member Author

That's an error I've never seen.
I think the dataset is this one https://renku-ci-ui-1656.dev.renku.ch/datasets/62b66820055e4a40bdb0d219d73030e6 and it's easy to reproduce by importing it in any other proejct.
I cannot find the reference project test-2022-01-21-14-11-17 though. That has probably been removed. Maybe that's the reason?

I guess in that case the dataset should not appear anymore in the search? @SwissDataScienceCenter/renku-graph-maintainers
Screenshot_20220124_151639

@jachro
Copy link

jachro commented Jan 24, 2022

That's an error I've never seen. I think the dataset is this one https://renku-ci-ui-1656.dev.renku.ch/datasets/62b66820055e4a40bdb0d219d73030e6 and it's easy to reproduce by importing it in any other proejct. I cannot find the reference project test-2022-01-21-14-11-17 though. That has probably been removed. Maybe that's the reason?

I guess in that case the dataset should not appear anymore in the search? @SwissDataScienceCenter/renku-graph-maintainers Screenshot_20220124_151639

Yes, that's probably what has happened, the project got removed. Generally, acceptance tests remove the project at the end of each test and the name of the project suggests that it's a test created project.

@ciyer
Copy link
Contributor

ciyer commented Jan 24, 2022

I see. So the problem is unrelated to this PR, and should hopefully get fixed when the KG handles deletions. I will approve then!

Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1656 January 25, 2022 08:33 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1656 January 25, 2022 10:27 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-1656 January 25, 2022 13:19 Inactive
@lorenzo-cavazzi lorenzo-cavazzi merged commit 9533723 into 1.0-next Jan 25, 2022
@lorenzo-cavazzi lorenzo-cavazzi deleted the 0000-fix-add-dataset branch January 25, 2022 16:00
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants