-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): restore projects data used by datasets #1656
Conversation
You can access the deployment of this PR at https://renku-ci-ui-1656.dev.renku.ch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an error I've never seen. I guess in that case the dataset should not appear anymore in the search? @SwissDataScienceCenter/renku-graph-maintainers |
Yes, that's probably what has happened, the project got removed. Generally, acceptance tests remove the project at the end of each test and the name of the project suggests that it's a test created project. |
I see. So the problem is unrelated to this PR, and should hopefully get fixed when the KG handles deletions. I will approve then! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
b0087e0
to
611c1a1
Compare
Tearing down the temporary RenkuLab deplyoment for this PR. |
This fixes a bug spotted by @gavin-k-lee that prevents datasets to be added to projects.
How to test: look for a dataset using the dataset search, open any and click on the "Add to project" button on the top right.
The user should be able to look for a project again and import the dataset (if the target project is up-to-date).
Trying the some on dev won't work -- the user won't even be able to select a target project.
P.S. We should probably check also the source project version. That may not be straightforward in the current implementation.
I would suggest re-working a bit the "add to project" logic, removing the overcomplicated FormGenerator Autosuggest (it's half-bugged, not checking for the input data to be available and not filtering some unusable target projects), adding the required logic for checking migrations on both sides.
/deploy renku=1.0-next renku-graph=development renku-core=v1.0.2