fix: do not show renkulab down when the users auth token has expired #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can access the deployment of this PR at https://renku-ci-ui-1788.dev.renku.ch |
lorenzo-cavazzi
approved these changes
Apr 12, 2022
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The fact that the server response was caused by an expired token was getting lost, so it was not possible to handle the error correctly at higher levels. This has been fixed.
Testing: Log into the Keycloak admin console and set the SSO Session Idle and Client Session Idle values to something very short (like 1 min). This will provoke more frequent auth token expirations, and you will be redirected to login, but you should not see the "RenklabDown" warning.
Fix #1759
/deploy renku=auto-update/renku-core-1.2.1 #persist