Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing project display #1843

Merged
merged 1 commit into from
May 16, 2022
Merged

fix: missing project display #1843

merged 1 commit into from
May 16, 2022

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented May 13, 2022

The dataset page should show the projects a dataset is used in, even if there is just one.

image

But the project dataset page should not (if there is just one).

image

/deploy renku=000-tests-ui-2_0-next #persist

@ciyer ciyer requested a review from a team as a code owner May 13, 2022 13:03
ciyer pushed a commit that referenced this pull request May 13, 2022
@ciyer ciyer force-pushed the 1842-show-dataset-project branch from 9fe558c to dee3a34 Compare May 13, 2022 13:03
@ciyer ciyer force-pushed the 1842-show-dataset-project branch from dee3a34 to cb29de9 Compare May 13, 2022 13:04
@ciyer ciyer deployed to renku-ci-ui-1843 May 13, 2022 13:11 Active
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-1843.dev.renku.ch

Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix.
One question: is it guaranteed that the dataset will always be at least in a project?

@ciyer ciyer merged commit 35b810e into master May 16, 2022
@ciyer ciyer deleted the 1842-show-dataset-project branch May 16, 2022 07:25
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants