Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded calls to gitlab graphql on the dataset view page #1912

Closed
rokroskar opened this issue Jun 17, 2022 · 3 comments
Closed

remove unneeded calls to gitlab graphql on the dataset view page #1912

rokroskar opened this issue Jun 17, 2022 · 3 comments
Assignees

Comments

@rokroskar
Copy link
Member

On the dataset view page (e.g. https://renkulab.io/datasets/5cbf90e140fd49b88789c659f5a499a8) the only API call needed is https://renkulab.io/ui-server/api/kg/datasets/5cbf90e140fd49b88789c659f5a499a8 - instead there are a number of calls to the core service and gitlab that are made, slowing down the page render. We should eliminate these extra calls as much as possible.

@ciyer
Copy link
Contributor

ciyer commented Jul 12, 2023

When you are on the project > datasets list page and navigate to one of the datasets, the UI is responsive only makes two calls.

image

The problem comes more from retrieving a bunch of information about project and datasets in general when navigating directly to a dataset page.

@lorenzo-cavazzi
Copy link
Member

Let's try to remove the early query to https://renkulab.io/datasets/5cbf90e140fd49b88789c659f5a499a8

@lorenzo-cavazzi lorenzo-cavazzi moved this from In Progress 🧑‍💻 to Todo 📌 in UI Sprints - DEPRECATED Jul 19, 2023
@andre-code andre-code self-assigned this Jul 26, 2023
@andre-code andre-code moved this from Todo 📌 to In Progress 🧑‍💻 in UI Sprints - DEPRECATED Jul 26, 2023
@andre-code
Copy link
Contributor

This Issue is closed because it is no longer reproducible in the current code base. Upon review, we found that the issue was probably addressed when refactoring dataset components #2415

@github-project-automation github-project-automation bot moved this from In Progress 🧑‍💻 to Done ✅ in UI Sprints - DEPRECATED Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants