-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the sessions polling to the server and notify using the websocket channel #2016
Comments
We should start with a first POC using the sessions notifications to re-fetch content only when we are not in a session page.
|
Repository owner
moved this from Review 🔎
to Done ✅
in UI Sprints - DEPRECATED
Dec 6, 2022
Repository owner
moved this from Review 🔎
to Done ✅
in UI Sprints - DEPRECATED
Dec 6, 2022
Repository owner
moved this from Todo
to Done
in MIX Feature Team
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
As a follow-up to #1338, we should stop looping for the sessions in the UI client and move the logic to the UI server.
Plan
This is broadly how this should work:
SERVER
CLIENT
INFO
A stub of the code is already available here https://github.com/SwissDataScienceCenter/renku-ui/blob/master/server/src/websocket/handlers/sessions.ts
Please mind that this was made for a previous POC and the logic has changed a bit in the meanwhile (E.G. we might not want "session-id" or "storage" anymore, we can cache on the channel
data
property; we also want to notify all the channels directly from the function).The text was updated successfully, but these errors were encountered: