Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui state tracking the session status (#2095) #2098

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Oct 27, 2022

Closes #2095

/deploy extra-values=notebooks.amalthea.resourceUsageCheck.enabled=true #persist

@andre-code andre-code temporarily deployed to renku-ci-ui-2098 October 27, 2022 15:27 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2098.dev.renku.ch

@andre-code andre-code temporarily deployed to renku-ci-ui-2098 October 27, 2022 15:46 Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2098 October 28, 2022 07:28 Inactive
@andre-code andre-code marked this pull request as ready for review October 28, 2022 07:32
@andre-code andre-code requested a review from a team as a code owner October 28, 2022 07:32
@andre-code andre-code force-pushed the 2095-fix-ui-state-for-sessions branch from 9563ab2 to 1ae3d44 Compare October 28, 2022 08:40
@andre-code andre-code temporarily deployed to renku-ci-ui-2098 October 28, 2022 08:41 Inactive
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this, and the progress is displayed properly here (compared to dev, where progress happens all at once).

@andre-code andre-code temporarily deployed to renku-ci-ui-2098 October 28, 2022 12:18 Inactive
@andre-code andre-code deployed to renku-ci-ui-2098 October 28, 2022 14:08 Active
@andre-code andre-code merged commit f5bd4db into master Oct 31, 2022
@andre-code andre-code deleted the 2095-fix-ui-state-for-sessions branch October 31, 2022 10:04
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ui state is no tracking well the session status
3 participants