Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cheatsheet based on renku-python json file #2112

Merged
merged 1 commit into from
Nov 8, 2022
Merged

feat: add cheatsheet based on renku-python json file #2112

merged 1 commit into from
Nov 8, 2022

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Nov 2, 2022 •
edited by lorenzo-cavazzi
Loading

PR to create cheatsheet based on renku-python json file

/deploy extra-values=gateway.gitlabUrl=https://gitlab.dev.renku.ch/ #persist

fix #1920

@andre-code andre-code changed the title feat: add cheatsheet based on renku-python json file WIP feat: add cheatsheet based on renku-python json file Nov 2, 2022
@RenkuBot
Copy link
Contributor

RenkuBot commented Nov 2, 2022

You can access the deployment of this PR at https://renku-ci-ui-2112.dev.renku.ch

@andre-code andre-code force-pushed the 1920-cheatsheet-based-on-renku-python branch from f84db74 to 1fc25c3 Compare November 2, 2022 14:32
@andre-code andre-code temporarily deployed to renku-ci-ui-2112 November 2, 2022 14:32 Inactive
@andre-code andre-code force-pushed the 1920-cheatsheet-based-on-renku-python branch from 1fc25c3 to 412536a Compare November 4, 2022 15:44
@andre-code andre-code changed the title WIP feat: add cheatsheet based on renku-python json file eat: add cheatsheet based on renku-python json file Nov 7, 2022
@andre-code andre-code force-pushed the 1920-cheatsheet-based-on-renku-python branch from 412536a to 4a3969a Compare November 7, 2022 08:22
@andre-code andre-code changed the title eat: add cheatsheet based on renku-python json file feat: add cheatsheet based on renku-python json file Nov 7, 2022
@andre-code andre-code marked this pull request as ready for review November 7, 2022 08:23
@andre-code andre-code requested a review from a team as a code owner November 7, 2022 08:23
@andre-code andre-code temporarily deployed to renku-ci-ui-2112 November 7, 2022 08:23 Inactive
@andre-code andre-code force-pushed the 1920-cheatsheet-based-on-renku-python branch from 4a3969a to 935115b Compare November 7, 2022 08:58
@andre-code andre-code temporarily deployed to renku-ci-ui-2112 November 7, 2022 08:58 Inactive
ciyer
ciyer requested changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very well, and I like that it is now much easier to ensure that the UI cheat sheet is in sync with the renku-python cheat sheet.

I have some suggestions around the code to prepare for supporting multiple versions of the cheat sheet.

client/src/notebooks/components/SessionCheatSheet.tsx Outdated Show resolved Hide resolved
client/src/notebooks/components/SessionCheatSheet.tsx Outdated Show resolved Hide resolved
@andre-code andre-code force-pushed the 1920-cheatsheet-based-on-renku-python branch from 935115b to 54a76de Compare November 7, 2022 12:53
@andre-code andre-code temporarily deployed to renku-ci-ui-2112 November 7, 2022 12:53 Inactive
@andre-code andre-code force-pushed the 1920-cheatsheet-based-on-renku-python branch from 54a76de to 6d08448 Compare November 7, 2022 13:21
@andre-code andre-code deployed to renku-ci-ui-2112 November 7, 2022 13:21 Active
ciyer
ciyer approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! This should help us keep the cheat sheets in sync! 🎉

@andre-code andre-code merged commit 8fd82f6 into master Nov 8, 2022
@andre-code andre-code deleted the 1920-cheatsheet-based-on-renku-python branch November 8, 2022 12:26
@RenkuBot
Copy link
Contributor

RenkuBot commented Nov 8, 2022

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciyer ciyer ciyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate generation of cheatsheet based on renku-python
4 participants
@andre-code @RenkuBot @ciyer @lorenzo-cavazzi