Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the "Renku version" message is correct #2135

Closed
lorenzo-cavazzi opened this issue Nov 10, 2022 · 1 comment · Fixed by #2503
Closed

Verify the "Renku version" message is correct #2135

lorenzo-cavazzi opened this issue Nov 10, 2022 · 1 comment · Fixed by #2503
Assignees
Labels

Comments

@lorenzo-cavazzi
Copy link
Member

Description

On PR deployments, we occasionally show a "New version" message even when the API response from cache.migrations_check doesn't suggest required actions (see screenshot).
It's possible things change recently, we should double-check if this works fine on our side.

image (5)

Reproduce

Use a non-tagged version of renku-core. E.G. open a PR and use /deploy renku-core=develop #persist and create a new project from that deployment.

@lorenzo-cavazzi
Copy link
Member Author

More info: we show the message based on (among the others) dockerfile_renku_status.newer_renku_available.
So far, we use this convention:

  • true means update
  • false means no-update
  • null means there might be an update

We should consider null as "we don't have enough information on the project version" and show such a message.
This should not happen in production (unless the project is very old) but it's common on our dev cluster

@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Mar 17, 2023
@lorenzo-cavazzi lorenzo-cavazzi moved this from Todo 📌 to In Progress 🧑‍💻 in UI Sprints - DEPRECATED Mar 29, 2023
@github-project-automation github-project-automation bot moved this from In Progress 🧑‍💻 to Done ✅ in UI Sprints - DEPRECATED May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant