Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create issues for refactoring datasets #2247

Closed
lorenzo-cavazzi opened this issue Dec 21, 2022 · 1 comment
Closed

Create issues for refactoring datasets #2247

lorenzo-cavazzi opened this issue Dec 21, 2022 · 1 comment
Assignees

Comments

@lorenzo-cavazzi
Copy link
Member

lorenzo-cavazzi commented Dec 21, 2022

Go through the datasets code and:

  • Identify the duplicated data from the KG/core APIs
  • Chat with KG/python teams and agree on how to proceed here (hint: until we have a dataset service, we should probably fetch data from renku-core, and then fetch extra info from KG and enrich the UI. If KG is indexing, we should re-fetch KG info later; if it's not indexed, we should show a prominent warning pushing the user to index the project. Making it a 2 steps approach, core first then KG, would simplify the logic too)
  • Define a clear strategy for the components and add detailed info to the issues. That should include how to tackle tasks like removing the form generator (hint: this might involve using notifications coming from the UI server fed by our brand new RabbitMQ 🐰 )
  • Dataset UI components should manage their own redux state. Currently, they rely on Project to do this (see Project.js>mapStateToProps and >subComponents -- this code can be cleaned up and moved to the dataset component)
@lorenzo-cavazzi
Copy link
Member Author

Here is the follow-up issue with detailed information.

#2415

No changes to the current KG/core implementations needed.

@github-project-automation github-project-automation bot moved this from Todo 📌 to Done ✅ in UI Sprints - DEPRECATED Mar 10, 2023
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

1 participant