Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate object store inputs #2287

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Validate object store inputs #2287

merged 2 commits into from
Jan 13, 2023

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jan 11, 2023 •
edited
Loading

Screenshots

image

image

image

image

Testing

  • The endpoint must be a valid URL
  • The bucket name must be at least 3 characters, contain only lowercase characters, numbers, '.', or '-', and must start and end with a letter or number

Fix #2210

/deploy #persist #cypress renku=000-cypres-tests-new-search

ciyer pushed a commit that referenced this pull request Jan 11, 2023
@cramakri
feat: add object store input validation (#2210) (#2287)
3571dd4 
Fix #2210
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2287.dev.renku.ch

@ciyer ciyer temporarily deployed to renku-ci-ui-2287 January 11, 2023 15:36 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2287 January 12, 2023 08:17 — with GitHub Actions Inactive
ciyer pushed a commit that referenced this pull request Jan 13, 2023
@cramakri
feat: add object store input validation (#2210) (#2287)
6c944d9 
Fix #2210
@ciyer ciyer temporarily deployed to renku-ci-ui-2287 January 13, 2023 10:02 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review January 13, 2023 10:02
@ciyer ciyer requested a review from a team as a code owner January 13, 2023 10:02
@ciyer ciyer temporarily deployed to renku-ci-ui-2287 January 13, 2023 12:41 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2287 January 13, 2023 13:20 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2287 January 13, 2023 13:49 — with GitHub Actions Inactive
lorenzo-cavazzi
lorenzo-cavazzi approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I fixed a typo and made the modal full-screen on smaller screens. Feel free to change it if you don't like it.

@ciyer ciyer merged commit 46f9f0e into master Jan 13, 2023
@ciyer ciyer deleted the 2210-object-store branch January 13, 2023 16:36
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate Endpoint field in the Object Store Configuration (aka S3)
4 participants
@ciyer @RenkuBot @lorenzo-cavazzi @cramakri