Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove collaboration tab #2365

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Remove collaboration tab #2365

merged 2 commits into from
Feb 10, 2023

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Feb 8, 2023

Screenshots

image

image

Testing

  • Check that Open in GitLab, Issues, Merge Requests, and Web IDE links work
  • Check that creating a dataset in a project where the default branch is protected shows a message with a correct link

Fix #2256

/deploy #cypress #persist renku=renku-ui-3.2.0-tests

@ciyer ciyer force-pushed the 2256-collab branch 2 times, most recently from b000ee5 to d46acb4 Compare February 8, 2023 12:02
@ciyer ciyer temporarily deployed to renku-ci-ui-2365 February 9, 2023 13:08 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

RenkuBot commented Feb 9, 2023

You can access the deployment of this PR at https://renku-ci-ui-2365.dev.renku.ch

@ciyer ciyer temporarily deployed to renku-ci-ui-2365 February 9, 2023 13:32 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2365 February 9, 2023 13:38 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2365 February 9, 2023 14:31 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-2365 February 9, 2023 16:15 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review February 9, 2023 17:30
@ciyer ciyer requested a review from a team as a code owner February 9, 2023 17:30
@ciyer ciyer temporarily deployed to renku-ci-ui-2365 February 10, 2023 11:06 — with GitHub Actions Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well!

I added a code suggestion to use standard components on the dropdown instead of linking the onClick action to window.open

Comment on lines 23 to 27
const onClick = () => window.open(url, "_blank");
return (
<DropdownItem onClick={onClick} size={size}>
{text}
</DropdownItem>
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

window.open doesn't allow the typical interactions offered by an anchor element.
In other similar scenarios, we use the ExternalLink component with the nav-link class. I suggest adopting the same solution here

Suggested change
const onClick = () => window.open(url, "_blank");
return (
<DropdownItem onClick={onClick} size={size}>
{text}
</DropdownItem>
);
return (
<DropdownItem onClick={onClick} size={size}>
<ExternalLink className="nav-link" role="text" title={text} url={url} />
</DropdownItem>
);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion, I have incorporated it.

@ciyer ciyer temporarily deployed to renku-ci-ui-2365 February 10, 2023 14:53 — with GitHub Actions Inactive
@ciyer ciyer deployed to renku-ci-ui-2365 February 10, 2023 16:20 — with GitHub Actions Active
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ciyer ciyer merged commit 0d4d703 into master Feb 10, 2023
@ciyer ciyer deleted the 2256-collab branch February 10, 2023 17:13
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Collaboration tab from project pages
4 participants