Dashboard: fix issue with trying to process deleted project data #2465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the API `/projects/<project>?statistics=false&doNotTrack=true` 404 response is processed as project data. We now skip these items. Fixes #2437.
leafty
commented
Apr 12, 2023
Comment on lines
+131
to
+132
| if (projectData.status === "fulfilled" && !projectData.value.error) | ||
| projectList.push(formatProjectMetadata(projectData.value.data)); |
There was a problem hiding this comment.
Note: it seems that the { error: e as FetchBaseQueryError } return below is not processed; the error seems to be silently swallowed in client/src/utils/customHooks/useGetRecentlyVisitedProjects.ts.
lorenzo-cavazzi
had a problem deploying
to
renku-ci-ui-2465
GitHub Actions
Error
|
You can access the deployment of this PR at https://renku-ci-ui-2465.dev.renku.ch |
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2465
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2465
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2465
GitHub Actions
Inactive
lorenzo-cavazzi
temporarily deployed
to
renku-ci-ui-2465
GitHub Actions
Inactive
…hboard-deleted-project
…hboard-deleted-project
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the API
/projects/<project>?statistics=false&doNotTrack=true404 response is processed as project data. We now skip these items./deploy #persist #cypress renku=renku-ui-3.4.2-updates
Fixes #2437.