Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use kg to update avatar (#2778) #2806

Merged
merged 17 commits into from
Oct 11, 2023
Merged

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Sep 20, 2023

PR to use kg api to update project's avatar.

Contents of this PR:

  • Modification of the updateProject mutation in the projectKgApi to override the project-kg-metadata tag when a project is modified. Avatar should be updated in the Project Header immediately after the change.
  • Introduction of a new component for online submit Image input.
  • Integration of a storybook for the online submit image input component: Storybook Link.

update project avatar

/deploy renku-graph=development #persist

@andre-code andre-code changed the base branch from master to 2778-use-kg-to-update-project September 20, 2023 15:33
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 September 20, 2023 15:34 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2806.dev.renku.ch

@andre-code andre-code temporarily deployed to renku-ci-ui-2806 September 21, 2023 11:22 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 September 21, 2023 13:21 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 September 27, 2023 09:27 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 September 27, 2023 12:47 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 September 27, 2023 20:29 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 September 28, 2023 12:01 — with GitHub Actions Inactive
@andre-code andre-code marked this pull request as ready for review September 28, 2023 13:57
@andre-code andre-code requested a review from a team as a code owner September 28, 2023 13:57
@andre-code andre-code changed the title [wip] feat: use kg to update avatar (#2778) feat: use kg to update avatar (#2778) Sep 28, 2023
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 October 4, 2023 14:13 — with GitHub Actions Inactive
@andre-code
Copy link
Contributor Author

Thank you for your review, @lorenzo-cavazzi. I have updated the input helper text to display a more accurate message regarding the limits of the image to upload compared to the image after cropping. It's possible that the calculation of the file size after crop and resize could be greater than the expected final size, and this message reflects that accurately.

I have also improved the parsing of error messages when there is an issue with changing the image. With these two changes, it now looks like this:

Screenshot 2023-10-04 at 15 23 21

@andre-code andre-code temporarily deployed to renku-ci-ui-2806 October 5, 2023 06:59 — with GitHub Actions Inactive
ciyer
ciyer previously requested changes Oct 5, 2023
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks very good! 🎉 I'm still doing some manual testing, but I have a couple of small suggestions about the code.

@andre-code andre-code temporarily deployed to renku-ci-ui-2806 October 9, 2023 11:36 — with GitHub Actions Inactive
@andre-code andre-code requested a review from ciyer October 9, 2023 11:37
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 October 9, 2023 14:31 — with GitHub Actions Inactive
leafty
leafty previously approved these changes Oct 10, 2023
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 October 10, 2023 12:44 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 October 10, 2023 15:31 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 October 10, 2023 20:48 — with GitHub Actions Inactive
@andre-code andre-code temporarily deployed to renku-ci-ui-2806 October 10, 2023 21:18 — with GitHub Actions Inactive
@andre-code andre-code dismissed stale reviews from ciyer and lorenzo-cavazzi October 11, 2023 11:30

changes implemented, reviewer not available

@andre-code andre-code merged commit 2492968 into master Oct 11, 2023
17 checks passed
@andre-code andre-code deleted the 2778-use-kg-to-update-avatar branch October 11, 2023 11:31
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants