-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use kg to update avatar (#2778) #2806
Conversation
You can access the deployment of this PR at https://renku-ci-ui-2806.dev.renku.ch |
081b38f
to
8c56b21
Compare
8c56b21
to
5070775
Compare
21d044e
to
0ed1795
Compare
c850521
to
21d1e03
Compare
0ed1795
to
d83671d
Compare
d83671d
to
cd18a34
Compare
cd18a34
to
e9c0de0
Compare
e9c0de0
to
0f718b2
Compare
0f718b2
to
3fccdef
Compare
3fccdef
to
4530d71
Compare
Thank you for your review, @lorenzo-cavazzi. I have updated the input helper text to display a more accurate message regarding the limits of the image to upload compared to the image after cropping. It's possible that the calculation of the file size after crop and resize could be greater than the expected final size, and this message reflects that accurately. I have also improved the parsing of error messages when there is an issue with changing the image. With these two changes, it now looks like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks very good! 🎉 I'm still doing some manual testing, but I have a couple of small suggestions about the code.
client/src/features/project/components/ProjectSettingAvatar.tsx
Outdated
Show resolved
Hide resolved
client/src/features/project/components/ProjectSettingAvatar.tsx
Outdated
Show resolved
Hide resolved
client/src/features/project/components/ProjectSettingAvatar.tsx
Outdated
Show resolved
Hide resolved
client/src/features/project/components/ProjectSettingAvatar.tsx
Outdated
Show resolved
Hide resolved
client/src/features/project/components/ProjectSettingAvatar.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Flora Thiebaut <flora.thiebaut@sdsc.ethz.ch>
changes implemented, reviewer not available
Tearing down the temporary RenkuLab deplyoment for this PR. |
PR to use kg api to update project's avatar.
Contents of this PR:
/deploy renku-graph=development #persist