Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forking private projects #2830

Closed
olevski opened this issue Oct 3, 2023 · 3 comments
Closed

Forking private projects #2830

olevski opened this issue Oct 3, 2023 · 3 comments
Labels
status/waiting-on-response Waiting on response from author

Comments

@olevski
Copy link
Member

olevski commented Oct 3, 2023

I have reports from a class where the students are added as Reporter members to a private group. The idea is that they should fork one of the private projects in this group and then work on the fork.

Here is what they are seeing:

Teaching assistant:

Sometimes students cannot fork the session. It seems to happen to students that just have been added to the student group.
Camille found a workaround that is a bit strange: he upgrades the student membership to "developer" inside the student group. Then the student is able to fork the session. Once this is done, the membership can be downgraded and the student can fork other sessions.
I found this workaround strange because the student group membership in the sessions repos is always "reporter", and some students (including my dummy student account) never had to be upgraded from "reporter" to "developer" to fork the sessions.

Instructor:

forking from the UI is often not possible as the button is greyed out, BUT it’s possible when going under sessions, and there there is a message suggesting to fork as the user does not have permissions

@olevski olevski added bug status/triage Issue needs to be triaged labels Oct 3, 2023
@olevski
Copy link
Member Author

olevski commented Oct 3, 2023

I think that the groups here are nested. I.e. it is something like /year/class/project, where year and class are nested groups. And students are added only to class, not year or the other way around. So it could be that we do not see this with a simple case with 1 level of nesting. But several levels of nesting may produce the error.

@lorenzo-cavazzi lorenzo-cavazzi added status/waiting-on-response Waiting on response from author and removed status/triage Issue needs to be triaged labels Nov 1, 2023
@lorenzo-cavazzi
Copy link
Member

lorenzo-cavazzi commented Nov 1, 2023

Thank you for reporting this. It's not totally clear to me what's the issue since "forking a session" is not really a thing.

Generally speaking, users need to be developers to create a project in a namespace, reporter is not enough. That's not required to start a session. So the following feedback is not surprising and it doesn't sound like a workaround to me

he upgrades the student membership to "developer" inside the student group. Then the student is able to fork the session. Once this is done, the membership can be downgraded and the student can fork other sessions.

I suspect those users fork projects in a group namespace as developers, and then they later push commits as reporters. That setup sounds far from ideal since other students could push code in their repos. If they use that to keep project visible to the whole group, perhaps having projects in their own namespace and sharing guest permissions to the groups is a better solution.

@lorenzo-cavazzi
Copy link
Member

Closing this, but please feel free to contact me directly; happy to talk about this point.

@lorenzo-cavazzi lorenzo-cavazzi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-on-response Waiting on response from author
Projects
None yet
Development

No branches or pull requests

2 participants