feat(client): Add UI/UX improvements #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre-code
had a problem deploying
to
renku-ci-ui-2845
GitHub Actions
Failure
|
You can access the deployment of this PR at https://renku-ci-ui-2845.dev.renku.ch |
andre-code
force-pushed
the
andrea/000-ui-fixes
branch
from
eb5ab99
to
906fc37
Compare
andre-code
had a problem deploying
to
renku-ci-ui-2845
GitHub Actions
Failure
andre-code
force-pushed
the
andrea/000-ui-fixes
branch
from
906fc37
to
14c07d8
Compare
andre-code
had a problem deploying
to
renku-ci-ui-2845
GitHub Actions
Failure
andre-code
force-pushed
the
andrea/000-ui-fixes
branch
from
14c07d8
to
ea54a1c
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2845
GitHub Actions
Inactive
andre-code
force-pushed
the
andrea/000-ui-fixes
branch
from
ea54a1c
to
2d4b702
Compare
andre-code
temporarily deployed
to
renku-ci-ui-2845
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2845
GitHub Actions
Inactive
andre-code
changed the title
andre-code
temporarily deployed
to
renku-ci-ui-2845
GitHub Actions
Inactive
andre-code
had a problem deploying
to
renku-ci-ui-2845
GitHub Actions
Failure
leafty
previously requested changes
Oct 12, 2023
There was a problem hiding this comment.
Thanks @andre-code! 👏
The visual changes look good to me, I have added a few blocking comments and a bunch of non-blocking notes.
client/src/features/session/components/options/SessionClassOption.module.scss
Outdated
Show resolved
Hide resolved
…ps and remove session button in about session modal
andre-code
force-pushed
the
andrea/000-ui-fixes
branch
from
2d4b702
to
0c25608
Compare
andre-code
had a problem deploying
to
renku-ci-ui-2845
GitHub Actions
Failure
andre-code
temporarily deployed
to
renku-ci-ui-2845
GitHub Actions
Inactive
andre-code
temporarily deployed
to
renku-ci-ui-2845
GitHub Actions
Inactive
ciyer
approved these changes
Oct 18, 2023
andre-code
dismissed
leafty’s stale review
Suggestions included in this PR and reviewer no available
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request is dedicated to enhancing the accessibility and user-friendliness of our user interface. To achieve this, we are focusing on three key areas:
Text Color Contrast:
We have changed the text color contrast across the user interface. This includes adjusting font colors to ensure optimal readability, making it easier for all users to interact with our platform. The selected colors align with browser-suggested options that meet recommended contrast ratios, and we've used our existing color palette as a reference.
Input Border Appearance and Background Colors:
Changes for input elements to make visually distinct and user-friendly. We've made changes to input borders and background colors to ensure they meet the recommended accessibility standards. These adjustments contribute to a more cohesive and inclusive user experience.
Note: This PR does not include changes to our main brand colors such as "renku-green" and "renku-pink." These modifications will be addressed separately in a future PR, once the new color definitions are provided by the product UI.
In addition this PR introduces more informative tooltips throughout the interface. We've also taken the opportunity to fix several bugs in various components, contributing to a more stable and reliable user experience.
In details..
- Change alert color texts
Before:
After:
- Change tex light color, use in time caption, slug
Before:
After:
Before:
After:
Before:
After:
- Adjust font weight to bold to ensure compliance with contrast ratios on dark backgrounds.
- Fix component to do not show double connect button in sessions
- Improve contrast color in inputs
- Fix tooltip position and add more descriptive texts
Before:
After:
Rel #2846
/deploy #persist