-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): prevent session issues for uppercase namespaces #2874
Conversation
You can access the deployment of this PR at https://renku-ci-ui-2874.dev.renku.ch |
P.S: making a namespace uppercase requires some effort; the easiest way is to go to GitLab, create a new group, and manually update the group namespace to make it uppercase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggested changes:
In client/src/components/list/ListBarSessions.tsx - L255, you can also add the session name:
<SessionButton fullPath={fullPath} gitUrl={gitUrl} runningSessionName={notebook.name} />
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Tearing down the temporary RenkuLab deplyoment for this PR. |
Projects with uppercase namespaces were messing up sessions, resulting in:
This PR fixes it (in the screenshot, left is on "dev" and right is on the current PR).
/deploy