Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): prevent session issues for uppercase namespaces #2874

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

lorenzo-cavazzi
Copy link
Member

Projects with uppercase namespaces were messing up sessions, resulting in:

  • Wrong feedback on the sessions dropdown menu in both the header and the dashboard (in the screenshot, all projects are paused but the last one shows "Start" instead of "Resume").
  • Missing sessions in the project's session tab.

This PR fixes it (in the screenshot, left is on "dev" and right is on the current PR).

image

/deploy

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner October 31, 2023 12:40
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2874 October 31, 2023 12:41 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2874.dev.renku.ch

@lorenzo-cavazzi
Copy link
Member Author

P.S: making a namespace uppercase requires some effort; the easiest way is to go to GitLab, create a new group, and manually update the group namespace to make it uppercase.
Here is a test project: https://gitlab.dev.renku.ch/uppercase-group/UPPER/uppercase-namespace

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2874 October 31, 2023 13:11 — with GitHub Actions Inactive
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggested changes:

In client/src/components/list/ListBarSessions.tsx - L255, you can also add the session name:

<SessionButton fullPath={fullPath} gitUrl={gitUrl} runningSessionName={notebook.name} />

client/src/features/session/sessions.utils.ts Outdated Show resolved Hide resolved
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2874 November 1, 2023 10:32 — with GitHub Actions Inactive
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2874 November 2, 2023 08:26 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi merged commit a3747a4 into master Nov 2, 2023
17 checks passed
@lorenzo-cavazzi lorenzo-cavazzi deleted the 0000-fix-dashboard branch November 2, 2023 11:01
@RenkuBot
Copy link
Contributor

RenkuBot commented Nov 2, 2023

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants