Update libraries to fix issues in audit #657
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciyer
force-pushed
the
0-update-libraries
branch
3 times, most recently
from
a39cd96
to
ac4b4cc
Compare
lorenzo-cavazzi
previously approved these changes
Nov 1, 2019
There was a problem hiding this comment.
I didn't find any relevant issue with the new version of the libraries 🎉
There is only a warning appearing on page load introduced by react 16.9 to inform about the use of deprecated lifecicle functions
Warning: componentWillMount has been renamed, and is not recommended for use.
We should consider removing them.
ciyer
force-pushed
the
0-update-libraries
branch
2 times, most recently
from
22a1513
to
74fb084
Compare
lorenzo-cavazzi
previously approved these changes
Nov 1, 2019
ciyer
force-pushed
the
0-update-libraries
branch
3 times, most recently
from
8af518f
to
a99da8b
Compare
|
All works, as lorenzo said we do get some warning, also when runing tests (for componentWillMount and componentWillReceiveProps) we should make new issues for replacing this. I also get an error for the notebook display... but the test passes and the notebook files can be displayed. |
ciyer
force-pushed
the
0-update-libraries
branch
from
a99da8b
to
185024f
Compare
- updated dev libraries - updated @babel/helper-regex, ajv, apollo-boost, d3, graphql, http-proxy, human-time, uuid - updated dompurify and showdown - updated node-sass-chokidar - update react-media and react-redux
ciyer
force-pushed
the
0-update-libraries
branch
from
185024f
to
044efc4
Compare
lorenzo-cavazzi
approved these changes
Nov 7, 2019
|
This has been superseded by #673, which is a superset of these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have not updated the libraries in a while and there are some issues that have been discovered in the dependencies. This update should fix currently known critical issues.
An issue was found with mouse pointer flickering caused by tooltips on mouseover in Chrome (e.g., the launch, gitlab, and lineage icons in the file view). This was a problem before this update, and we have only upgraded some of the libraries to avoid having this problem. After this update, it occasionally occurs, but in a manageable amount. Hopefully, updating the libraries to the latest major version (#666) will resolve this problem.
The PR is available for testing at https://sekhar.dev.renku.ch/