fix(datasets): if a dataset fails we display non-failed datasets

[vfried]

Closes #924

In case a dataset fetch fails all dataset fetch was failing.

This was causing a "no dataset inside this project" message.

Now in case a dataset can't be fetched we display all the datasets that where fetched with no problem.

I also replaced some calls to get dataset for simplified ones when we don't need to get all the dataset info (i.e redirect after dataset add).

[vfried]

To make a dataset fail you can do this...

Inside /api-client/project.js you choose a dataset that you want to make fail and change "NAME-OF-DATASET-THAT-WILL-FAIL" for the name of the dataset that will fail

 client.getProjectDatasetsFromKG = (projectPath) => {
    let url = `${client.baseUrl}/knowledge-graph/projects/${projectPath}/datasets`;
    url = url.replace("/api", "");//The url should change in the backend so we don't have to do this
    const headers = client.getBasicHeaders();
    return client.clientFetch(url, { method: "GET", headers }).then((resp) => {
      return resp.data;
    }).then(resp => {
      let fullDatasets = resp.map(dataset => {
        if (dataset.name === "NAME-OF-DATASET-THAT-WILL-FAIL")
          return client.fetchDatasetFromKG(dataset._links[0].href + "123");
        return client.fetchDatasetFromKG(dataset._links[0].href);
      });
      return Promise.all(fullDatasets);
    });
  };

[ciyer]

Code looks good. I just have a question about the change because it silently drops datasets that return an error when we try to retrieve the full information. Do you think this is the right behavior, or should we show the information we have for those datasets with a message the the full dataset could not be retrieved?

[ciyer]

Can you explain why you switched from getProjectDatasetsFromKG to getProjectDatasetsFromKG_short here?

[vfried]

The get projects from KG fetches the datasets list and also the details of the dataset (this means one call per dataset plus one call to get the datasets list). The dataset import fetches de dataset list to see if there was a dataset added and if there is it redirects the user. We don't need all the dataset details that the getProjectDatasetFromKG gives. Maybe i whould rename the functions to "getProjectDatasetsFromKgEnriched" and "getProjectDatasetFromKG"

[ciyer]

👍 I like the name getProjectDatasetsFromKgEnriched

[ciyer]

Would it make sense to put in a placeholder for the dataset that failed, showing the information we have and a message that the dataset could not be retrieved?

[vfried]

I made a comment about this bellow... i think that we shouldn't overthink this because it will change soon since kuba will return datasets enriched from the KG.

[vfried]

What happens here is that i get from the KG a list of datasets that has an error, then i try to fetch details from this list and this is when the error makes things fail. This should not happen... i shouldn't be getting from the backend a list that has an error. This is why i decided to drop the error instead of displaying something. (What is causing this error to happen is that there are two datasets with the same ID if i understand correctly, this is why i say this error shouldn't happen).

After kuba finishes this SwissDataScienceCenter/renku-graph#298 we will stop fetching dataset per dataset and will have to change this anyways... hopefully this should be solved also so i wouldn't put to many effort on fixing something that will change soon.

[ciyer]

👍