Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): when the editor is in code mode on edit is now disabled #957

Merged
merged 3 commits into from
Jun 8, 2020
Merged

fix(editor): when the editor is in code mode on edit is now disabled #957

merged 3 commits into from
Jun 8, 2020

Conversation

vfried
Copy link
Contributor

@vfried vfried commented Jun 4, 2020 •
edited
Loading

Closes #953

To test this:

  • go to dev
  • pick a dataset to modify
  • change the editor to "code view"
  • you will be able to modify (but not to save) the dataset description
  • do this again on this branch and you will not be able to do this

@vfried vfried requested a review from a team as a code owner June 4, 2020 06:33
ciyer
ciyer approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vfried vfried merged commit 620576c into master Jun 8, 2020
@ciyer ciyer deleted the 953-ckeditor-fix branch June 29, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciyer ciyer ciyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a dataset is on "modify" mode the editor in markdown mode should be deactivated
2 participants
@vfried @ciyer