Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly handle missing description field in project page #978

Merged
merged 2 commits into from
Jul 10, 2020
Merged

fix: properly handle missing description field in project page #978

merged 2 commits into from
Jul 10, 2020

Conversation

lorenzo-cavazzi
Copy link
Member

#961 got merged to handle projects without a Description field. This PR fixes a couple of minor leftovers:

  1. Avoid React error on project's setting tab page
    Screenshot_20200709_153840

  2. Avoid <br /> element adding extra space on top of the project's overview page
    Screenshot_20200709_154029

@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner July 9, 2020 13:51
@lorenzo-cavazzi lorenzo-cavazzi added this to the sprint-2020-07-09 milestone Jul 9, 2020
ciyer
ciyer approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lorenzo-cavazzi lorenzo-cavazzi merged commit e5423fd into master Jul 10, 2020
@lorenzo-cavazzi lorenzo-cavazzi deleted the 000-project-fixes branch July 10, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciyer ciyer ciyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sprint-2020-07-09
Development

Successfully merging this pull request may close these issues.
2 participants
@lorenzo-cavazzi @ciyer