feat: allow anonymous user navigation in the project's collaboration tab #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues APIs require authentication to get the full discussion. This PR uses an undocumented GitLab API to allow anonymous users to access the same content. It's the same API currently used in the GitLab UI. More details https://gitlab.com/gitlab-org/gitlab/-/issues/217369 fix #905
ciyer
requested changes
Jul 22, 2020
|
I see the same content 🤔 It's possible that the gateway pod was not up-to-date?
|
ciyer
approved these changes
Jul 23, 2020
ciyer
pushed a commit
that referenced
this pull request
Sep 9, 2020
…tab (#987) Use undocumented GitLab API to allow anonymous users to access public issues discussions. The API is currently used in the GitLab UI. Reference: https://gitlab.com/gitlab-org/gitlab/-/issues/217369 fix #905 (cherry picked from commit a6fe6fe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues APIs require authentication to get the full discussion. This PR uses an undocumented GitLab API to allow anonymous users to access the same content. It's the same API currently used in the GitLab UI. More details in this discussions https://gitlab.com/gitlab-org/gitlab/-/issues/217369
It requires SwissDataScienceCenter/renku-gateway#251
fix #905
Preview
https://lorenzotest.dev.renku.ch
How to test
Check issues on a public project as an anonymous users.
This is a sample project: https://lorenzotest.dev.renku.ch/projects/noemail/scratch-project/collaboration/issues/1/