Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional parameter to turn off the PDF generation #278

Merged
merged 11 commits into from
Apr 26, 2022

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Apr 25, 2022

I'm introducing the new parameter to turn off the PDF generation:

sylius_invoicing:
    pdf_generator:
        enabled: false

The main reason for adding this parameter is to not force wkhtmtopdf to be installed.

@GSadee GSadee added the Feature New feature proposals. label Apr 25, 2022
@GSadee GSadee requested a review from a team as a code owner April 25, 2022 18:44
Comment on lines +207 to +213
-
name: Remove wkhtmltopdf binary
run: rm tests/Application/etc/wkhtmltopdf

-
name: Disable PDF generation
run: mv tests/Application/etc/sylius_invoicing_pdf_generation_disabled.yaml tests/Application/config/packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only these two steps are different perhaps we can plug this build again to the the main one with included following values:

                php: "8.1"
                symfony: "^5.4"
                sylius: "~1.11.0"
                node: "14.x"
                mysql: "8.0"
                pdf: false

and the add

Suggested change
-
name: Remove wkhtmltopdf binary
run: rm tests/Application/etc/wkhtmltopdf
-
name: Disable PDF generation
run: mv tests/Application/etc/sylius_invoicing_pdf_generation_disabled.yaml tests/Application/config/packages
-
name: Remove wkhtmltopdf binary
if: matrix.pdf != ''
run: rm tests/Application/etc/wkhtmltopdf
-
name: Disable PDF generation
if: matrix.pdf != ''
run: mv tests/Application/etc/sylius_invoicing_pdf_generation_disabled.yaml tests/Application/config/packages

@lchrusciel lchrusciel merged commit 85725ef into Sylius:master Apr 26, 2022
@GSadee GSadee deleted the turn-off-pdf-generation branch April 26, 2022 12:40
lchrusciel added a commit that referenced this pull request Apr 27, 2022
…bled to the main workflow (GSadee)

This PR was merged into the master branch.

Discussion
----------

According to the comment: #278 (comment)

Commits
-------

acfa44c [GitHub Actions] Include build with PDF generation disabled to the ma…
af16a2e [GitHub Actions] Merge steps for disabling PDF generation into one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants