Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symfony 6 support #296

Merged
merged 12 commits into from
Nov 8, 2022
Merged

Add Symfony 6 support #296

merged 12 commits into from
Nov 8, 2022

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Oct 13, 2022

To be merged on Sylius 1.12 release 💃

In addition, #295 and #294 should be merged before this one then the rebase will be needed.

@coldic3 coldic3 force-pushed the feature/symfony6-support branch 2 times, most recently from a64e124 to 46f7774 Compare October 13, 2022 14:43
@coldic3 coldic3 marked this pull request as ready for review October 13, 2022 14:52
@coldic3 coldic3 requested a review from a team as a code owner October 13, 2022 14:52
@coldic3 coldic3 force-pushed the feature/symfony6-support branch 2 times, most recently from cfb1fe1 to 9e3217b Compare October 14, 2022 06:45
@coldic3 coldic3 force-pushed the feature/symfony6-support branch from 9e3217b to bb5fb1b Compare October 17, 2022 10:42
GSadee added a commit that referenced this pull request Nov 2, 2022
….4 (coldic3)

This PR was merged into the main branch.

Discussion
----------

To be merged on Sylius 1.12 release 💃

It could be a nice intermediate step. Support for Symfony 6 is added in a separate PR: #296.

Commits
-------

83a1fc9 [Maintenance] Add support for Sylius 1.12 but without Symfony 6
8541151 Replace gulp with webpack
b16e680 [Maintenance] Fix deprecations
fed2e88 [GitHub Actions] Add Sylius 1.12 to the matrix
4b4592a [Maintenance] Add support for both Swiftmailer and SF Mailer in the test app
8bd5d6f [Maintenance] Add Flysystem to the bundles for Sylius 1.12
27e98bd [Behat] Fix contexts
@GSadee GSadee force-pushed the feature/symfony6-support branch from be28c1f to 4d9d941 Compare November 4, 2022 06:21
@GSadee GSadee changed the title [WIP] Symfony 6 support Add Symfony 6 support Nov 4, 2022
@GSadee GSadee added Feature New feature proposals. Maintenance Configurations, READMEs, releases, etc. Dependencies Pull requests that update a dependency file labels Nov 4, 2022
@GSadee GSadee force-pushed the feature/symfony6-support branch 2 times, most recently from 97a17d6 to ce1b0ed Compare November 4, 2022 07:00
@GSadee GSadee force-pushed the feature/symfony6-support branch from 98c81c0 to 029c64f Compare November 4, 2022 08:40
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@GSadee GSadee merged commit 14a8add into Sylius:main Nov 8, 2022
@GSadee
Copy link
Member

GSadee commented Nov 8, 2022

Thank you, Kevin! 🎉

GSadee added a commit that referenced this pull request Nov 9, 2022
This PR was merged into the main branch.

Discussion
----------

PR based on #296 – rebase needed before the merge.

Before:
![image](https://user-images.githubusercontent.com/13316080/198647293-14f3e04b-7d0e-4453-b17d-009a60ffb27c.png)

After:
![image](https://user-images.githubusercontent.com/13316080/198646845-68458a5b-62db-49ff-b7ec-0dd119d86cce.png)

Commits
-------

cf81c1c [Templates] Fix styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Feature New feature proposals. Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants