-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 2.0 #323
Merged
Merged
Upgrade to 2.0 #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
Oct 11, 2024
•
edited
Loading
edited
TheMilek
force-pushed
the
SYL-3915
branch
3 times, most recently
from
October 11, 2024 13:33
9dd3574
to
69f045a
Compare
TheMilek
force-pushed
the
SYL-3915
branch
12 times, most recently
from
October 13, 2024 21:05
10c56e7
to
571ff5a
Compare
Wojdylak
reviewed
Oct 14, 2024
run: vendor/bin/behat --colors --strict -vvv --no-interaction -f progress || vendor/bin/behat --colors --strict -vvv --no-interaction -f progress --rerun | ||
run: | | ||
if [ "${{ matrix.wkhtmltopdf }}" != "false" ]; then | ||
vendor/bin/behat --colors --strict -vvv --no-interaction -f progress --tags="~@pdf_disabled" || vendor/bin/behat --colors --strict -vvv --no-interaction -f progress --rerun; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did it work before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont really know, but seems like the extension friends-of-behat/exclude-specifications-extension
was doing the trick before
src/templates/admin/invoice/show/content/page_body/buyer.html.twig
Outdated
Show resolved
Hide resolved
src/templates/admin/invoice/show/content/page_body/buyer/company.html.twig
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Oct 15, 2024
src/templates/admin/invoice/show/content/page_body/seller.html.twig
Outdated
Show resolved
Hide resolved
TheMilek
force-pushed
the
SYL-3915
branch
2 times, most recently
from
October 16, 2024 06:41
dc74d02
to
3869edd
Compare
Wojdylak
approved these changes
Oct 16, 2024
src/templates/admin/invoice/show/content/header/title_block/actions/back_to_index.html.twig
Outdated
Show resolved
Hide resolved
src/templates/admin/invoice/show/content/sections/card/footer.html.twig
Outdated
Show resolved
Hide resolved
TheMilek
force-pushed
the
SYL-3915
branch
5 times, most recently
from
October 17, 2024 11:36
33ce137
to
a33aa2c
Compare
GSadee
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.