Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddressOrderHandler missing company/phone #435

Closed
hashnz opened this issue Apr 30, 2019 · 3 comments
Closed

AddressOrderHandler missing company/phone #435

hashnz opened this issue Apr 30, 2019 · 3 comments
Labels
Maintenance Minor

Comments

@hashnz
Copy link
Contributor

hashnz commented Apr 30, 2019

The call to add an address from the cart doesn't handle the company or phoneNumber fields, just wondering if this is intentional, if not I can submit a PR

https://github.com/Sylius/ShopApiPlugin/blob/master/src/Handler/Cart/AddressOrderHandler.php
@mamazu
Copy link
Member

mamazu commented May 2, 2019

This is a missing feature. Please submit a pull request but leave those parameters optional I'd say.

@GSadee GSadee mentioned this issue May 2, 2019
Closed
@hashnz
Copy link
Contributor Author

hashnz commented May 2, 2019

Here you go: #442

@mamazu
Copy link
Member

mamazu commented Jun 9, 2019

Closed by merging #442

@mamazu mamazu closed this as completed Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Maintenance Minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hashnz @mamazu