Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel as parameter #513

Closed
antonioperic opened this issue Aug 11, 2019 · 5 comments
Closed

Channel as parameter #513

antonioperic opened this issue Aug 11, 2019 · 5 comments

Comments

@antonioperic
Copy link
Contributor

Suggestion:
It will be very nice to have the option to send a channel as a parameter. This is API so supplying different devices with different settings is not something that is rarely.

@mamazu
Copy link
Member

mamazu commented Aug 11, 2019

True. Channels are still a big topic in the development of shop api. I would suggest to reword the ticket for better documentation of how channels can be extracted in shop api. As far as I know you can register your own classes to determine the channel all by yourself.

@antonioperic
Copy link
Contributor Author

@mamazu that will be nice, if we don't have that out of the box

@lchrusciel
Copy link
Member

@antonioperic this feature should work with different hostnames out-of-the-box. Similar to default Sylius. But this should be documented

@antonioperic
Copy link
Contributor Author

@lchrusciel i know, but most APIs will have one hostname
different hostnames works out of the box

@mamazu
Copy link
Member

mamazu commented Aug 14, 2019

Is fixed by #514. At least the documentation bit.

@mamazu mamazu closed this as completed Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants