Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Validation on Customer Gender #617

Merged
merged 3 commits into from
Jan 1, 2020

Conversation

Amr3zzat
Copy link
Contributor

Add Validation on Gender field [Update Customer Request]
Gender Filed will only accept these letters ['u', 'm', 'f'].
related issue #614

@Amr3zzat Amr3zzat requested a review from a team as a code owner December 27, 2019 15:00
@mamazu
Copy link
Member

mamazu commented Dec 28, 2019

Looks good, so far. If you could fix the tests it would be great. And maybe add a test that tests the validation (so that when the user enters an invalid gender it returns a 400).

@Amr3zzat Amr3zzat force-pushed the Add-Gender-Validation-Update-User branch from a600ce5 to 9dc55c2 Compare December 30, 2019 20:58
@Amr3zzat
Copy link
Contributor Author

@mamazu I have fixed the old test , add new test for this case

@mamazu mamazu merged commit 310bdfc into Sylius:master Jan 1, 2020
@mamazu
Copy link
Member

mamazu commented Jan 1, 2020

Thank you, Amr! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants