Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Update installation guide #739

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

coldic3
Copy link
Contributor

@coldic3 coldic3 commented Jan 11, 2023

ShopAPI firewall config differs depending on the SF version.

@coldic3 coldic3 requested a review from a team as a code owner January 11, 2023 10:53
Comment on lines +71 to +75
parameters:
# ...

sylius.security.shop_regex: "^/(?!admin|api/.*|api$|shop-api|media/.*)[^/]++" # shop-api has been added inside the brackets
sylius_shop_api.security.regex: "^/shop-api"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As parameters and also access_control are the same for both cases, they can be extracted before the firewall config which depends on the version of Symfony

@GSadee GSadee merged commit 5eb9811 into Sylius:1.6 Jan 12, 2023
@GSadee
Copy link
Member

GSadee commented Jan 12, 2023

Thank you, Kevin! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants