Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Extract Grid component & bundle #10326

Merged
merged 1 commit into from
Apr 29, 2019
Merged

[WIP] Extract Grid component & bundle #10326

merged 1 commit into from
Apr 29, 2019

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Apr 23, 2019

Related to #10179.

@pamil pamil requested a review from a team as a code owner April 23, 2019 03:38
@pamil pamil added the Maintenance CI configurations, READMEs, releases, etc. label Apr 23, 2019
@pamil pamil force-pushed the 1.1-grid-bundle branch from bd70bba to 295f7e6 Compare April 23, 2019 03:40
@pamil pamil mentioned this pull request Apr 23, 2019
Closed
6 tasks
@pamil pamil changed the title Extract Grid component & bundle [WIP] Extract Grid component & bundle Apr 23, 2019
@pamil pamil changed the title [WIP] Extract Grid component & bundle Extract Grid component & bundle Apr 26, 2019
@pamil pamil force-pushed the 1.1-grid-bundle branch from 295f7e6 to 68a3e2e Compare April 26, 2019 08:25
@pamil pamil changed the title Extract Grid component & bundle [WIP] Extract Grid component & bundle Apr 26, 2019
lchrusciel
lchrusciel approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

I just wanted to mention, that Resource bundle is coupled with Grid. Hopefully pretty loosely
image

@pamil pamil merged commit 595de75 into Sylius:1.1 Apr 29, 2019
@pamil pamil deleted the 1.1-grid-bundle branch April 29, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pamil @lchrusciel