Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch timeframe on admin dashboard #11558

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented Jun 9, 2020

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? not sure
Deprecations? not sure
Related tickets
License MIT

ezgif com-video-to-gif

TODO: Block possibility to move timeframe in future after the time we have today

@arti0090 arti0090 requested a review from a team as a code owner June 9, 2020 08:27
@GSadee GSadee added Admin AdminBundle related issues and PRs. Feature New feature proposals. UX Issues and PRs aimed at improving User eXperience. labels Jun 9, 2020
@arti0090 arti0090 force-pushed the switch-admin-dashboard-timeframe branch from 18387ee to 8b51e30 Compare June 10, 2020 11:22
@@ -5,53 +5,95 @@ class StatisticsComponent {
constructor(wrapper) {
if (!wrapper) return;

this.weekInMiliSeconds = 604800000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.weekInMiliSeconds = 604800000;
this.weekInMiliseconds = 604800000;

@GSadee GSadee merged commit 110508b into Sylius:master Jun 12, 2020
@GSadee
Copy link
Member

GSadee commented Jun 12, 2020

Thanks, @arti0090! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. Feature New feature proposals. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants