[Api][Checkout] cover skipping payment steps in behat #11705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Jul 31, 2020
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
AdamKasp
force-pushed
the
api-skipping-payment-step
branch
from
d59972b to
4162c6b
Compare
GSadee
approved these changes
Jul 31, 2020
AdamKasp
force-pushed
the
api-skipping-payment-step
branch
4 times, most recently
from
808b5ed to
4d279a3
Compare
AdamKasp
force-pushed
the
api-skipping-payment-step
branch
3 times, most recently
from
82b97ac to
e0d9e47
Compare
GSadee
reviewed
Aug 4, 2020
features/checkout/leaving_notes_on_order_during_checkout.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutShippingContext.php
Outdated
Show resolved
Hide resolved
Comment on lines
60
to
63
| $shippingMethodName = 'Free'; | ||
| if ($shippingMethod !== null) { | ||
| $shippingMethodName = $shippingMethod->getName(); | ||
| } |
There was a problem hiding this comment.
Why did you add it? Shipping method shouldn't be null
There was a problem hiding this comment.
Because i reuse function iSelectShippingMethod where ShippingMethod can be null because function: iProceedSelectingBillingCountryAndShippingMethod can have null as a agument
src/Sylius/Behat/Context/Ui/Shop/Checkout/CheckoutShippingContext.php
Outdated
Show resolved
Hide resolved
| @@ -41,21 +42,25 @@ public function __construct( | |||
| } | |||
|
|
|||
| /** | |||
| * @Given I have proceeded selecting :shippingMethodName shipping method | |||
| * @When I proceed with :shippingMethodName shipping method | |||
| * @Given I have proceeded selecting :shippingMethod shipping method | |||
There was a problem hiding this comment.
What is the reason you changed the implementation of steps in ui context?
There was a problem hiding this comment.
at one of the API steps, I needed to get shippingMethod instead shipping method name that implicated changes also in UI steps
There was a problem hiding this comment.
I understand, but this shouldn't force changes in UI context, you can have it implemented @Given I have proceeded selecting :shippingMethodName shipping method in UI context and @Given I have proceeded selecting :shippingMethod shipping method in API context
GSadee
reviewed
Aug 4, 2020
src/Sylius/Behat/Resources/config/suites/api/checkout/checkout.yml
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
api-skipping-payment-step
branch
from
badf27b to
bebcbc2
Compare
AdamKasp
force-pushed
the
api-skipping-payment-step
branch
2 times, most recently
from
e1d9ea1 to
df96304
Compare
AdamKasp
force-pushed
the
api-skipping-payment-step
branch
from
df96304 to
d32ff14
Compare
GSadee
approved these changes
Aug 5, 2020
| /** | ||
| * @Then I should not see any information about payment method | ||
| */ | ||
| public function iShouldNotSeeAnyInformationAboutPaymentMethod() |
There was a problem hiding this comment.
Suggested change
| public function iShouldNotSeeAnyInformationAboutPaymentMethod() | |
| public function iShouldNotSeeAnyInformationAboutPaymentMethod(): void |
| @@ -116,7 +117,7 @@ public function iProceedSelectingPaymentMethod($paymentMethodName) | |||
| * @Given I have proceeded order with :shippingMethodName shipping method and :paymentMethodName payment | |||
| * @When I proceed with :shippingMethodName shipping method and :paymentMethodName payment | |||
| */ | |||
| public function iProceedOrderWithShippingMethodAndPayment($shippingMethodName, $paymentMethodName) | |||
| public function iProceedOrderWithShippingMethodAndPayment(string $shippingMethodName, $paymentMethodName) | |||
There was a problem hiding this comment.
Suggested change
| public function iProceedOrderWithShippingMethodAndPayment(string $shippingMethodName, $paymentMethodName) | |
| public function iProceedOrderWithShippingMethodAndPayment(string $shippingMethodName, string $paymentMethodName): void |
|
Thank you, Adam! 🎉 |
GSadee
added a commit
that referenced
this pull request
Aug 7, 2020
This PR was merged into the 1.8-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | based on #11705 | License | MIT <!-- - Bug fixes must be submitted against the 1.7 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- fb50dab [Api] Fix failing steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.