-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Api][checkout] product integrity validation #11750
Merged
GSadee
merged 5 commits into
Sylius:master
from
AdamKasp:api-product-integrity-validation
Aug 21, 2020
Merged
[Api][checkout] product integrity validation #11750
GSadee
merged 5 commits into
Sylius:master
from
AdamKasp:api-product-integrity-validation
Aug 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Aug 19, 2020
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Related tickets | part of #11250 |
License | MIT |
lchrusciel
reviewed
Aug 20, 2020
AdamKasp
force-pushed
the
api-product-integrity-validation
branch
3 times, most recently
from
August 20, 2020 08:40
fd1e4e6
to
543b522
Compare
AdamKasp
force-pushed
the
api-product-integrity-validation
branch
from
August 20, 2020 13:56
02a2c83
to
e278350
Compare
AdamKasp
force-pushed
the
api-product-integrity-validation
branch
from
August 20, 2020 14:01
e278350
to
52780dd
Compare
arti0090
reviewed
Aug 21, 2020
src/Sylius/Behat/Resources/config/suites/api/checkout/paying_for_order.yml
Show resolved
Hide resolved
AdamKasp
changed the title
[WIP] Api product integrity validation
[Api][checkout] product integrity validation
Aug 21, 2020
GSadee
reviewed
Aug 21, 2020
src/Sylius/Bundle/ApiBundle/Resources/config/services/validator.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/validation/order.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderProductEligibilityValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Validator/Constraints/OrderProductEligibilityValidator.php
Show resolved
Hide resolved
AdamKasp
force-pushed
the
api-product-integrity-validation
branch
from
August 21, 2020 07:02
35a5f5c
to
431930b
Compare
GSadee
reviewed
Aug 21, 2020
AdamKasp
force-pushed
the
api-product-integrity-validation
branch
from
August 21, 2020 07:26
431930b
to
47d7766
Compare
GSadee
approved these changes
Aug 21, 2020
AdamKasp
force-pushed
the
api-product-integrity-validation
branch
from
August 21, 2020 08:24
47d7766
to
01f3890
Compare
AdamKasp
force-pushed
the
api-product-integrity-validation
branch
from
August 21, 2020 09:21
01f3890
to
6b1653a
Compare
Thank you, Adam! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.