[Api] restrict access to customer account editing #11874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Sep 24, 2020
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no/yes |
| New feature? | no/yes |
| BC breaks? | no/yes |
| Deprecations? | no |
| Related tickets | part of #11250, based on #11872 |
| License | MIT |
AdamKasp
changed the title
AdamKasp
changed the title
Tomanhez
reviewed
Sep 24, 2020
| } | ||
|
|
||
| if ( | ||
| $user instanceof ShopUserInterface && |
There was a problem hiding this comment.
Suggested change
| $user instanceof ShopUserInterface && | |
| $user instanceof ShopUserInterface && | |
| in_array('ROLE_USER', $user->getRoles(), true)) && |
| @@ -6,10 +6,10 @@ Feature: Editing a customer profile | |||
|
|
|||
| Background: | |||
| Given the store operates on a single channel in "United States" | |||
| And there is a customer "Francis Underwood" identified by an email "francis@underwood.com" and a password "whitehouse" | |||
| And there is a customer "Francis Underwood" identified by an email "francis@underwood.com" and a password "sylius" | |||
There was a problem hiding this comment.
Suggested change
| And there is a customer "Francis Underwood" identified by an email "francis@underwood.com" and a password "sylius" | |
| And there is a customer "Francis Underwood" identified by an email "francis@underwood.com" |
IMO its not needed in plain sight
GSadee
approved these changes
Sep 24, 2020
| /** @var ShopUserInterface $shopUser */ | ||
| $shopUser = $this->sharedStorage->get('user'); | ||
|
|
||
| $this->shopApiSecurityContext->iAmLoggedInAs($email); |
There was a problem hiding this comment.
This is different behaviour than in UI, for now, it's ok, but we should probably think about it in future
There was a problem hiding this comment.
Yes, i will investigate how to save token after customer change login, and i will add new PR with solution or add issue for it.
Comment on lines
+99
to
+104
| ->getItem( | ||
| CustomerInterface::class, | ||
| '2', | ||
| Request::METHOD_PUT, | ||
| [] | ||
| ) |
There was a problem hiding this comment.
It could be, but in rest of item providers we have similar formating and also IMO it is more readable in this way
|
Thank you, Adam! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.