[Api] Receiving percentage discount #12083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arti0090
approved these changes
Nov 25, 2020
| @@ -541,4 +565,22 @@ private function checkProductQuantity( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private function compareItemSubtotal(ProductInterface $product, \Closure $price): void | |||
There was a problem hiding this comment.
I see that very simillar or even the same function is here https://github.com/Sylius/Sylius/pull/12081/files/a2cef239265f11c566a0efbff8514ef2142685d4#diff-b5c163d690bfe47026cba0b16b71bdc7a4e1b0d95352b10522d4b0194d23e85dR555
Maybe we can think about another class that can have same function? 😉
There was a problem hiding this comment.
This is the same function because this PR is based on #12081
AdamKasp
approved these changes
Nov 25, 2020
Tomanhez
force-pushed
the
reciving-percentage-discount
branch
2 times, most recently
from
1d6d7e1 to
dcbfc00
Compare
Tomanhez
force-pushed
the
reciving-percentage-discount
branch
from
dcbfc00 to
25afe06
Compare
GSadee
approved these changes
Nov 26, 2020
|
Thanks, Tomasz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #12081