Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Architecture] Do not double install PHP dependencies #13513

Merged
merged 1 commit into from
Jan 20, 2022
Merged

[Architecture] Do not double install PHP dependencies #13513

merged 1 commit into from
Jan 20, 2022

Conversation

lchrusciel
Copy link
Member

Q A
Branch? 1.10
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Composer install is already part of architekt github action https://github.com/phparkitect/arkitect-github-actions/blob/main/entrypoint.sh#L23

@lchrusciel lchrusciel requested a review from a team as a code owner January 19, 2022 12:14
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jan 19, 2022
@GSadee GSadee merged commit 0913c3d into Sylius:1.10 Jan 20, 2022
@GSadee
Copy link
Member

GSadee commented Jan 20, 2022

Thank you, Łukasz! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roshyo Roshyo Roshyo approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lchrusciel @GSadee @Zales0123 @Roshyo