Add missing customer attributes to sylius_shop_api_me #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
approved these changes
Feb 8, 2019
lchrusciel
reviewed
Feb 11, 2019
- Added `birthday`, `gender`, `phoneNumber` and `subscribedToNewsletter` to sylius_shop_api_me response - Updated LoggedInCustomerDetails on doc/swagger.yml, to include the new attributes - Updated tests
nevoeiro
force-pushed
the
add_missing_customer_details_to_sylius_shop_api_me
branch
from
5e1222c
to
565e547
Compare
|
Thanks, @nevoeiro! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to load all user details through shopApi I suggest to change the response of
sylius_shop_api_me, adding the missing customer attributes:birthday,gender,phoneNumberandsubscribedToNewsletterHaving this, we can get and edit all customer attributes and that will be useful if you want to use Sylius as headless system, e.g.