[Customer] Refactor customer actions to use command providers #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GSadee
force-pushed
the
command-providers-customer
branch
3 times, most recently
from
c6b0d34
to
0816f5c
Compare
lchrusciel
approved these changes
Jul 25, 2019
| $this->bus->dispatch(new GenerateResetPasswordToken($request->request->get('email'))); | ||
| $this->bus->dispatch(new SendResetPasswordToken($request->request->get('email'), $channel->getCode())); | ||
| $this->bus->dispatch($this->generateResetPasswordTokenCommandProvider->getCommand($request)); | ||
| $this->bus->dispatch($this->sendResetPasswordTokenCommandProvider->getCommand($request, $channel)); |
There was a problem hiding this comment.
We could also refactor this action to be based on events in next iteration
| { | ||
| /** @var string */ | ||
| protected $token; | ||
|
|
||
| public function __construct(Request $request) | ||
| private function __construct(Request $request) |
There was a problem hiding this comment.
Quick though. As these classes are meant to be extended, maybe we should define constructors as protected so that they will be usable from child classes.
GSadee
force-pushed
the
command-providers-customer
branch
2 times, most recently
from
3b1467c
to
dfe7ae2
Compare
GSadee
force-pushed
the
command-providers-customer
branch
from
dfe7ae2
to
242ed10
Compare
lchrusciel
added a commit
that referenced
this pull request
Jul 25, 2019
…ors (GSadee) This PR was merged into the 1.0-dev branch. Discussion ---------- Based on #496 According to #493 (diff) Commits ------- df56a31 Change from private to protected for requests constructors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.