Add onHand to product response #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/product-on-hand
branch
8 times, most recently
from
310dadf to
8a91261
Compare
mamazu
approved these changes
Jul 30, 2019
|
Could you rebase this onto the current master? |
alexander-schranz
force-pushed
the
feature/product-on-hand
branch
from
8a91261 to
168ca19
Compare
|
@mamazu all rebased |
|
Thanks, Alexander! 🎉 |
|
@mamazu Thank you :) |
|
Thanks for the contribution. |
This was referenced Jul 31, 2019
mamazu
added a commit
that referenced
this pull request
Sep 21, 2019
mamazu
added a commit
that referenced
this pull request
Feb 3, 2020
…er-schranz, mamazu) This PR was merged into the 1.0-dev branch. Discussion ---------- I misinterpredted how sylius checks the availibility of a product when implementing #503. This will now use the correct [availibilityChecker](https://github.com/Sylius/Sylius/blob/v1.5.3/src/Sylius/Component/Inventory/Checker/AvailabilityChecker.php) service of sylius. Commits ------- 93f2a2c Add available property to ProductVariantView e695674 Adapt phpunit tests for available flag 5a6b696 Rebasing to the new master and fixing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to know how many products are still available.