Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add onHand to product response" #512

Merged
merged 2 commits into from
Sep 21, 2019

Conversation

lchrusciel
Copy link
Member

Reverts #503

@lchrusciel lchrusciel requested a review from a team as a code owner August 9, 2019 16:48
@mamazu
Copy link
Member

mamazu commented Aug 11, 2019

What's the problem with that?

@alexander-schranz
Copy link
Contributor

@mamazu As mentioned in #508 we should expose only availability flag and not how many are onHand or onHold. As I think onHand and onHold could be also sensitive data for a shop or?

@mamazu
Copy link
Member

mamazu commented Aug 19, 2019

There are two reasons why they should be reverted:

  1. the availability is based on more factors than just on hand and on hold quantity.
  2. @lchrusciel and I agreed that this might not be part of the 1.1 version as currently we are in a feature freeze phase.

@alexander-schranz
Copy link
Contributor

@mamazu

  1. yeah thats what I wanted to say.
  2. you mean not part of 1.0?

@mamazu
Copy link
Member

mamazu commented Aug 20, 2019

Yes, currently we are just trying to stabalize the current version and not introduce any new features.

@mamazu mamazu force-pushed the revert-503-feature/product-on-hand branch from 5a19ae4 to 2f96763 Compare September 21, 2019 13:49
@mamazu mamazu merged commit cfd1d42 into master Sep 21, 2019
@mamazu
Copy link
Member

mamazu commented Sep 21, 2019

Thanks, Łukasz! 🎉

@lchrusciel lchrusciel deleted the revert-503-feature/product-on-hand branch September 21, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants