Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in swagger file #522

Merged
merged 2 commits into from
Sep 9, 2019
Merged

Conversation

alexander-schranz
Copy link
Contributor

The https://app.swaggerhub.com/apis/Sylius/sylius-shop-api/1.0.0 is not up2date and the exist swagger.yml in doc/swagger.yml has same errors in it when copy it to https://editor.swagger.io/

@alexander-schranz alexander-schranz requested a review from a team as a code owner August 28, 2019 14:41
@mamazu
Copy link
Member

mamazu commented Aug 28, 2019

Yes, the api documentation on swaggerhub is currently not up to date as it is not Synchronized with the documentation of the main repository.

@lchrusciel lchrusciel merged commit 2ebde01 into Sylius:master Sep 9, 2019
@lchrusciel
Copy link
Member

Thank you, Alexander! 🥇

@alexander-schranz alexander-schranz deleted the patch-1 branch September 9, 2019 07:42
@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Sep 9, 2019

@lchrusciel thx for merging. Is it possible to update the swaggerhub file, the current one is kind of outdated and so missing some endpoints (e.g. register, password forget, ..): https://app.swaggerhub.com/apis/Sylius/sylius-shop-api/1.0.0

@lchrusciel
Copy link
Member

For now, I have opened an issue. I will try to do something about it

@mamazu
Copy link
Member

mamazu commented Sep 9, 2019

If there is an API for it we could use the github actions feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants