Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dependencies #579

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Fixing dependencies #579

merged 2 commits into from
Oct 14, 2019

Conversation

mamazu
Copy link
Member

@mamazu mamazu commented Oct 9, 2019

In the most recent version of phpstan's assert implementation the "implements" assertion has been added this howerver does not work with the current usage. I already made a pull request to fix it but other than that we need to exclude this version until it's fixed.

@mamazu mamazu requested a review from a team as a code owner October 9, 2019 09:21
@lchrusciel lchrusciel merged commit 0b3f67f into Sylius:master Oct 14, 2019
@lchrusciel
Copy link
Member

Thank you, @mamazu! 🥇

@mamazu mamazu deleted the fixing_dependencies branch October 14, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants