Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cart] Dispatch CartPickedUp after doctrine transaction #591

Merged
merged 1 commit into from
Nov 23, 2019
Merged

[Cart] Dispatch CartPickedUp after doctrine transaction #591

merged 1 commit into from
Nov 23, 2019

Conversation

lchrusciel
Copy link
Member

No description provided.

@lchrusciel lchrusciel requested a review from a team as a code owner October 30, 2019 10:46
@lchrusciel lchrusciel force-pushed the dispatch-events-after-doctrine-transactions branch from 17297cf to 93bd29a Compare October 30, 2019 10:47
@mamazu
Copy link
Member

mamazu commented Oct 30, 2019

We should definitely add documentation on how this works or maybe a link to the Symfony docs on this.

@lchrusciel
Copy link
Member Author

Absolutely. I will improve these PR's(this + #593) tomorrow.

@lchrusciel
Copy link
Member Author

Documented at: https://github.com/Sylius/ShopApiPlugin/pull/593/files#diff-5b6b3fb8d473fb4d84726dbc0e4f1188R40

@Zales0123 Zales0123 merged commit 7b03034 into Sylius:master Nov 23, 2019
@Zales0123
Copy link
Member

Thank you, Łukasz! 🥇

@lchrusciel lchrusciel deleted the dispatch-events-after-doctrine-transactions branch November 23, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees

@lchrusciel lchrusciel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lchrusciel @mamazu @Zales0123