Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Card as a Link Breaks Image Layout #411

Open
wesleyboar opened this issue Oct 21, 2024 · 2 comments
Open

Image Card as a Link Breaks Image Layout #411

wesleyboar opened this issue Oct 21, 2024 · 2 comments
Labels
enhancement Improvements or additions to existing features

Comments

@wesleyboar
Copy link
Member

wesleyboar commented Oct 21, 2024

Overview

Layout of image card ([class*="card--image"]) changes if image is a link.

Steps

  <article class="c-card c-card--plain c-card--image-top">
    <h3>Card - Image top</h3>
    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. In venenatis odio elit, faucibus blandit tellus mollis ut. Donec vel nibh at nisl fermentum sodales nec quis risus. Nullam et magna in metus vulputate fermentum a a augue.</p>
-   <img src="…">
+   <a href="…">
+     <img src="…">
+   </a>
  </article>

Expected

  • Zero visual change.
  • Image becomes a link.

Actual

  • Space is added around image.
  • Image becomes a link.

Core-Styles

Before After
styles before styles after

Core-CMS

Before Change After
no change what cms user changes change breaks layout
@wesleyboar wesleyboar added the enhancement Improvements or additions to existing features label Oct 29, 2024
@wesleyboar
Copy link
Member Author

fixed by #419

@wesleyboar
Copy link
Member Author

Reopened, because TACC/tup-ui#487 reveals bugs.

Warning

  1. Crop of image can change.
  2. Outline might be cropped.

@wesleyboar wesleyboar reopened this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or additions to existing features
Projects
None yet
Development

No branches or pull requests

1 participant