Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine whether Option::None fields should be serialized in Messages/Resources #38

Open
amika-sq opened this issue Dec 8, 2023 · 1 comment

Comments

@amika-sq
Copy link
Contributor

amika-sq commented Dec 8, 2023

In the tbDEX protocol spec, there are a lot of optional fields that can appear within a Resource/Message.

Currently, Rust will serialize those optional fields, even if they're empty. I don't believe that the spec explicitly defines if they should/shouldn't. We should come to resolution on this, and add in serialization skips for Option::None fields if they're necessary.

Link to comment with a few options on how we could handle this:
#37 (comment)

@mistermoe
Copy link
Member

good callout @amika-sq !

I don't believe that the spec explicitly defines if they should/shouldn't.

will surface this discussion today so we can resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants