[ Fix ] junior promise page QA 반영 #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ Related Issue
Closes #338
✅ Done Task
언제나 정신 똑바로 차리고 살아야 합니다..
헤더를 수정해도 반응조차 없길래.. 억장이 무너져 내렸는데 알고보니 지은이 뷰랑 연결된 헤더만 열심히 수정하고
확인은 제 뷰에서 했으니.. 얼마나 바보같은 짓을 하고 있었는지..
📢 지은이에게
하는김에 지은이 뷰 헤더도 수정했는데 피그마 상에 지은이 뷰는 헤더가 없더라구요?? 조건부 렌더링에는 지은이가 헤더를 해두었길래
일단 "transparent"헤더로 해두었는데.. 지은이 한 번 확인 부탁드림다~ (그래서 지은이 소환했어요)
💎 PR Point
커밋 순서대로, 커서 포인터 적용했구(적용할래요 버튼 색 들어오는 경우에만 커서포인터 수정했습니다),
바텀시트 직무부분 스크롤 안보이게 수정완료했습니다!
바뀐 헤더대로 수정 해두었습니다.
📸 Screenshot
default.mp4
default.mov
default.mov