add @scope to <language> by factoring a new class from @scope of att.handFeatures
#2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from att.impreciseScope to att.scope, per suggestion @martindholmes and agreement on TEI-CORRESP-SIG list.
…esp sig list discussion
|
@sydb After I merged in PR #2630 , I came back here to rerun the test on this PR. They failed again, but at first it was pretty simple: just needed to update specs + ST to reference att.scope instead of the original att.impreciseScope. I went through and just fixed that quickly, and after that we can build the Guidelines with this branch, but <bibl xml:id="bib4handnoteyi" xml:lang="en">
<author>Libelt, Karol</author>.
<title level="m" xml:lang="pl">Wykłady Humboldta na uniwersytecie Berlińskim: notaty prelekcyj tych po uczniu Jego Karolu Libelcie</title>,
<publisher xml:lang="de">Deutsches Textarchiv</publisher>,
<date>2024-04-02</date>.
<idno type="URN">urn:nbn:de:kobv:b4-30960-7</idno>,
<ptr target="https://www.deutschestextarchiv.de/book/download_xml/libelt_hs6623ii_1828"/>
<date type="accessed" when="2024-12-04"/>
</bibl> |
|
Of course...and I bet we can fix that by updating this branch from dev now... |
|
Huzzah! passes tests now... @sydb Think you this is ready for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic idea was to address #2516 by removing the definition of
@scopefrom att.handFeatures, modifying it slightly, and putting it into a new class "att.impreciseScope", then making both<language>and att.handFeatures members of that new class.This was a BLOCKED draft PR because it would not build until #2630 had merged. (Or changes are made here to account for the lack of #2630. :-) #2630 has been merged, so this PR is good to go.